This repository has been archived by the owner on Feb 15, 2022. It is now read-only.
Fixes Inability to Tap Screenshot on iOS 14 #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbbischoff
approved these changes
Sep 11, 2020
mliberatore
deleted the
fixes-inability-to-tap-screenshot-on-feedback-vc
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #276
What It Does
When building / deploying for iOS 14, tapping the screenshot button wasn’t working. This is due to the fact that the contents of the cell were beneath the cell’s content view, which was getting the touch events. This didn’t seem to bite us until iOS 14, but the fix is just to properly add / pin to the cell’s content view. I checked the other cell,
CheckmarkCellto be certain, and we’re not adding subviews there, so no similar issue exists.How to Test
On iOS 11, 12, 13, 14:
Notes
N/A